Skip to content

fix: deprecated tag <ray>, use <lidar> instead#676

Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom
Vangasse:master
Apr 14, 2025
Merged

fix: deprecated tag <ray>, use <lidar> instead#676
SteveMacenski merged 1 commit intoros-navigation:masterfrom
Vangasse:master

Conversation

@Vangasse
Copy link
Copy Markdown
Contributor

@Vangasse Vangasse commented Apr 11, 2025

While working with Gazebo Harmonic, I encountered an issue where the "ray" tag no longer seems to function as expected. After some troubleshooting, I found out by looking at the TurtleBot3 project that the documentation is currently outdated and replacing "ray" with "lidar" resolved the problem.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a depreciation warning? What was the issue that you ran into?

Please sign off your commit with DCO and we can merge!

Signed-off-by: vangasse <vangasse@ic.ufal.br>
@Vangasse
Copy link
Copy Markdown
Contributor Author

Vangasse commented Apr 14, 2025

Hi everyone,

Just wanted to clarify that the tag in Gazebo does still work as intended—I likely made an unrelated mistake elsewhere in the tutorial and fixed it without realizing. While "lidar" is indeed the preferred as "ray" is considered legacy, "ray" remains functional and serves the tutorial’s purpose well. As a bonus, it maintains backward compatibility with older Gazebo environments.

Since the legacy version remains fully functional, I’ll leave it to the reviewer’s discretion whether to adopt this update or maintain the current implementation. Happy to adjust either way!

Thanks for the attention.

@SteveMacenski SteveMacenski merged commit e440526 into ros-navigation:master Apr 14, 2025
4 checks passed
@SteveMacenski
Copy link
Copy Markdown
Member

Thanks for the info! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants